fix: repair failing tests and type errors across api and shared packages - #114
Open
stooit wants to merge 1 commit into
Open
fix: repair failing tests and type errors across api and shared packages#114stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
- auth middleware: fix case-sensitivity typo in public-method allow-list - shared types: rename User field to 'username' for cross-package consistency - users route: add missing 'badRequest' import - shared: implement paginate() utility (was a stub) - tsconfig: add bun-types to resolve process/bun:test globals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repairs all failing tests and TypeScript errors so
bun test && tsc --noEmitis fully green (22 tests pass, clean tsc). Fixes span both theapiandsharedpackages.Root causes & fixes
packages/api/src/middleware/auth.ts) — case-sensitivity bug in the HTTP-method comparison meantPOST /userswas not recognised as a public route (andprocessglobal was unresolved). Fixed the method check and type resolution.packages/shared/src/types.ts) — theUserfield was named inconsistently (userName) vs. what callers and tests expect (username). Renamed tousernamefor cross-package consistency; tests are the source of truth.packages/api/src/routes/users.ts) — missingbadRequestimport caused a runtime failure on the "returns 400 for missing fields" path. Added the import.packages/shared/src/utils/pagination.ts) — was a stub throwing "not implemented". Implementedpaginate()to satisfy the full contract: page slice +total,totalPages,page,pageSize, handling out-of-range pages, empty arrays, and partial last pages.bun-types(already present in the repo) soprocessandbun:testglobals resolve. No broad check-disabling.Verification
bun test→ 22 pass / 0 failtsc --noEmit→ exit 0 (clean)Constraints honoured
bun-typesalready in the repo).Assumptions
usernamefield name is canonical, chosen because the (unmodifiable) tests consistently use it.bun-typeswas already available in the repo, so tsconfig wiring is configuration only — nothing installed.